fix #4519: correcting how the config refreshes #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
reviewed
Oct 26, 2022
Comment on lines
+1463
to
+1469
| public void setFile(File file) { | ||
| this.file = file; | ||
| } | ||
|
|
||
| public void setAutoConfigure(boolean autoConfigure) { | ||
| this.autoConfigure = autoConfigure; | ||
| } |
There was a problem hiding this comment.
So that they will get set when we clone via the builder. We create modified configs in special circumstances, in particular with the withRequestConfig calls.
There was a problem hiding this comment.
From the generated io.fabric8.kubernetes.client.ConfigBuilder:
public Config build() {
Config buildable = new Config(fluent.getMasterUrl(),fluent.getApiVersion(),fluent.getNamespace(),fluent.isTrustCerts(),fluent.isDisableHostnameVerification(),fluent.getCaCertFile(),fluent.getCaCertData(),fluent.getClientCertFile(),fluent.getClientCertData(),fluent.getClientKeyFile(),fluent.getClientKeyData(),fluent.getClientKeyAlgo(),fluent.getClientKeyPassphrase(),fluent.getUsername(),fluent.getPassword(),fluent.getOauthToken(),fluent.getWatchReconnectInterval(),fluent.getWatchReconnectLimit(),fluent.getConnectionTimeout(),fluent.getRequestTimeout(),fluent.getRollingTimeout(),fluent.getScaleTimeout(),fluent.getLoggingInterval(),fluent.getMaxConcurrentRequests(),fluent.getMaxConcurrentRequestsPerHost(),fluent.isHttp2Disable(),fluent.getHttpProxy(),fluent.getHttpsProxy(),fluent.getNoProxy(),fluent.getErrorMessages(),fluent.getUserAgent(),fluent.getTlsVersions(),fluent.getWebsocketTimeout(),fluent.getWebsocketPingInterval(),fluent.getProxyUsername(),fluent.getProxyPassword(),fluent.getTrustStoreFile(),fluent.getTrustStorePassphrase(),fluent.getKeyStoreFile(),fluent.getKeyStorePassphrase(),fluent.getImpersonateUsername(),fluent.getImpersonateGroups(),fluent.getImpersonateExtras(),fluent.getOauthTokenProvider(),fluent.getCustomHeaders(),fluent.getRequestRetryBackoffLimit(),fluent.getRequestRetryBackoffInterval(),fluent.getUploadConnectionTimeout(),fluent.getUploadRequestTimeout());
buildable.setDefaultNamespace(fluent.isDefaultNamespace());
buildable.setAuthProvider(fluent.getAuthProvider());
buildable.setContexts(fluent.getContexts());
buildable.setCurrentContext(fluent.getCurrentContext());
buildable.setAutoConfigure(fluent.isAutoConfigure());
buildable.setFile(fluent.getFile());
return buildable;
}
|
I'm not sure you linked the correct issue number (at least I don't see their relation) |
shawkins
changed the title
shawkins
force-pushed
the
refresh_config
branch
from
83b2f43
to
e58016c
Compare
Sorry transposed the issue numbers. Corrected now. |
manusa
force-pushed
the
refresh_config
branch
from
e58016c
to
31efb15
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
approved these changes
Nov 8, 2022
|
SonarCloud Quality Gate failed. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for #4519 - refining how the config refreshes
It seems like a good idea also to always apply the system/env properties after loading the kubeconfig - https://github.com/fabric8io/kubernetes-client/compare/master...shawkins:refresh_config?expand=1#diff-7506ddc44edef04cb34dcde13c56d00ed3b1d35d848ded8f1924ed44c03db953R608
Type of change
test, version modification, documentation, etc.)
Checklist