Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4312: fix timestamp can't be deserialized for IstioCondition #4474

Merged
merged 3 commits into from Oct 17, 2022
Merged

Fix #4312: fix timestamp can't be deserialized for IstioCondition #4474

merged 3 commits into from Oct 17, 2022

Conversation

yimoucao
Copy link
Contributor

@yimoucao yimoucao commented Oct 3, 2022 •
edited

Description

Fix #4312

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Oct 4, 2022

cc/ @Sgitario

manusa
manusa requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@manusa manusa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to regenerate de model and persist the applicable generated classes changes.

You can read more about this at https://github.com/fabric8io/kubernetes-client/tree/master/kubernetes-model-generator

@yimoucao
Copy link
Contributor Author

yimoucao commented Oct 4, 2022

@manusa thx. I ll do it during some spare time

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

manusa
manusa approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 6.2.0 milestone Oct 17, 2022
@manusa manusa merged commit f243e69 into fabric8io:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@Sgitario Sgitario Sgitario approved these changes

@metacosm metacosm Awaiting requested review from metacosm

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

istio Timestamp type should be mapped to String type in java
4 participants
@yimoucao @manusa @oscerd @Sgitario