fix (openshift-client) : Change ManagedOpenShiftClient OSGi ConfigurationPolicy to REQUIRE (#3864) #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Sep 23, 2022
…tionPolicy to REQUIRE (fabric8io#3864) Just like ManagedKubernetesClient, ManagedOpenShiftClient also doesn't handle `activate()` being called with null properties. Setting Component configuration policy to REQUIRE which would make having configuration object for ManagedOpenShiftClient (i.e. `src/main/resources/assembly/etc/io.fabric8.openshift.client.cfg`) compulsory. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue3864
branch
from
7071732
to
7aa186c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3864
Just like ManagedKubernetesClient, ManagedOpenShiftClient also doesn't handle
activate()being called with null properties. Setting Component configuration policy to REQUIRE which would make having configuration object for ManagedOpenShiftClient (i.e.src/main/resources/assembly/etc/io.fabric8.openshift.client.cfg) compulsory.Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist