fix: provide more context when group/plural are missing #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
requested review from
manusa and
rohanKanojia
and removed request for
manusa
rohanKanojia
reviewed
Sep 7, 2022
...nerator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/HasMetadata.java
Outdated
Show resolved
Hide resolved
rohanKanojia
approved these changes
Sep 7, 2022
manusa
reviewed
Sep 8, 2022
| @Retention(RUNTIME) | ||
| public @interface Group { | ||
| String NAME = Group.class.getSimpleName(); |
There was a problem hiding this comment.
🤓 I'm curious about these constants. Does this provide performance improvements? what's the reasoning?
There was a problem hiding this comment.
Can probably be removed indeed as it "pollutes" the annotation's interface.
manusa
approved these changes
Sep 8, 2022
manusa
force-pushed
the
improve-error-handling
branch
from
8b5f98b
to
a18cb0d
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4396
Type of change
test, version modification, documentation, etc.)
Checklist