New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the generator-annotations version to 6.2-SNAPSHOT #4386

Merged

manusa merged 1 commit into fabric8io:master from fabiobrz:fix.bump-generator-annotations-62-SNAPSHOT

Sep 5, 2022

Contributor

fabiobrz commented Sep 5, 2022

Description

Bumping generator-annotations version to 6.2-SNAPSHOT, so that the snapshot can be built successfully.

Fixes #4385

Type of change

Bug fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change
Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

Code contributed by me aligns with current project license: Apache 2.0
N/A - I Added CHANGELOG entry regarding this change
N/A - I have implemented unit tests to cover my changes
N/A - I have added/updated the javadocs and other documentation accordingly
No new bugs, code smells, etc. in SonarCloud report
N/A - I tested my code in Kubernetes
N/A - I tested my code in OpenShift


          Bump the generator-annotations version to 6.2-SNAPSHOT

62d3add

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

andreaTP approved these changes

View reviewed changes

oscerd approved these changes

View reviewed changes

Member

andreaTP commented Sep 5, 2022

@fabiobrz any specific reason why this is still in draft?
Looks like a pretty straight misalignment created by concurrent release + PRs

andreaTP requested a review from manusa

September 5, 2022 09:24

fabiobrz marked this pull request as ready for review

September 5, 2022 09:39

Contributor Author

fabiobrz commented Sep 5, 2022 •

edited

@fabiobrz any specific reason why this is still in draft? Looks like a pretty straight misalignment created by concurrent release + PRs

Hi @andreaTP - no, not really. I was just following the guidelines and waiting for CI checks. IMO it's ready for merge now.

manusa approved these changes

View reviewed changes

Member

manusa left a comment

LGTM, thx for taking care

manusa merged commit e520e0d into fabric8io:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment