chore #3906: deprecating CustomResourceList #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/MIGRATION-v6.md
Outdated
| @@ -248,6 +248,8 @@ We've removed setter methods `setIntVal`, `setKind`, `setStrVal` from the class. | |||
|
|
|||
| The only exception to the above is `patch(PatchContext, item)` - it is valid to be called after withName. | |||
|
|
|||
| CustomResourceList was deprecated - use DefaultKubernetesResourceList instead. | |||
There was a problem hiding this comment.
This is supposed to be a list entry, right?
Suggested change
| CustomResourceList was deprecated - use DefaultKubernetesResourceList instead. | |
| - CustomResourceList was deprecated - use DefaultKubernetesResourceList instead. |
There was a problem hiding this comment.
@rohanKanojia I added your change along with making the previous line continue from the preceding bullet point.
rohanKanojia
approved these changes
Jun 29, 2022
|
Shall we also migrate these CustomResource classes in kubernetes-tests to use DefaultKubernetesResourceList? |
|
SonarCloud Quality Gate failed.
|
I'm fine if we wait until wait until the class is removed. |
manusa
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #3906 - by deprecating CustomResourceList as it provides no additional functionality.
Type of change
test, version modification, documentation, etc.)
Checklist