Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3628 removing sorting from lists and templates #3905

Merged
merged 1 commit into from Mar 1, 2022

Conversation

shawkins
Copy link
Contributor

Description

Removing built-in object sorting, which allows for the Template class to be generated.

This also address one of the errors from #3899 since the Template class now has the appropriate group.

With this change and changes from #3858 (removal of lists) I think the KubernetesList class only be a public construct for Templates.

I think the rationale for this sorting may have been to help with the creation order of items in a list - but that is not something that kubectl does and it does not seem expected that things get reordered.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Mar 1, 2022

I think the rationale for this sorting may have been to help with the creation order of items in a list - but that is not something that kubectl does and it does not seem expected that things get reordered.

I don't know about why it's in this project (I remember trying to track this down when fixing a bug, but there was nothing significant on the first implementation). In JKube, this ordering is reused precisely for that. Making sure that required/dependency resources get created prior to the rest of dependent resources.

@manusa manusa added this to the 6.0.0 milestone Mar 1, 2022
@manusa manusa merged commit 21ee5fb into fabric8io:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants