Chore #3637: Update Kubernetes Model to Kubernetes v1.23.0 #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
changed the title
|
Go Build is failing because it's now dependent on Go 17: kubernetes-sigs/controller-tools#643 . If we update image to golang 17 it should pass |
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Our Go Generator Build is now dependent on Go 1.17 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Since we've model updated to Kubernetes v1.23.0, it's better to also run E2E tests on Kubernetes 1.23.0. Add Kubernetes 1.23.0 to current list of Kubernetes versions on which E2E tests are being run.
rohanKanojia
force-pushed
the
pr/issue3637
branch
from
cf97f19
to
5703661
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
reviewed
Jan 10, 2022
| @@ -57,14 +57,14 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| kubernetes: [v1.22.1,v1.20.1,v1.19.2,v1.12.0] | |||
| kubernetes: [v1.23.0,v1.22.1,v1.20.1,v1.19.2,v1.12.0] | |||
There was a problem hiding this comment.
Maybe we can remove any non-significant version from the matrix (different PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3637
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist