Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2021-20218 vulnerable to a path traversal #2782

Merged
merged 2 commits into from Feb 4, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented Feb 3, 2021

Description

Provided fix and tests for path traversal vulnerability.

Added a partial copy of Apache Commons IO FilenameUtils to avoid adding any dependency, especially considering the fix might be back-ported to very early versions (>=v4.2.0).
The package for this copied classes (io.fabric8.kubernetes.client.lib) has been decided to avoid OSGi issues regarding exported and imported modules

Relates to:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@manusa
Copy link
Member Author

manusa commented Feb 3, 2021

n.b. K8s E2E tests won't pass in this version because the GH action is not compatible with the newly provided environment by GitHub (Ubuntu 20.04 as opposed to Ubuntu 18.04)

Same for Sonar task:

The version of Java (1.8.0_282) you have used to run this analysis is deprecated and we stopped accepting it. Please update to at least Java 11.

@manusa manusa force-pushed the fix/2715 branch 2 times, most recently from e473cf6 to a6844c8 Compare February 4, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants