fix: fromCustomResourceType is of type CustomResource
#2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
rohanKanojia
approved these changes
Dec 30, 2020
The method previously accepted a Class<? extends HasMetadata> which is wrong since the created instance is then casted to a CustomResource type.
manusa
force-pushed
the
fix/crd-context-from-custom-resource
branch
from
71f0738
to
6648179
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
[merge] |
oscerd
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2695: fromCustomResourceType should be of type
CustomResource.The method previously accepted a Class<? extends HasMetadata> which is wrong since the created instance is then casted to a CustomResource type.
Type of change
test, version modification, documentation, etc.)
Checklist