Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an integration test for BuildConfig instantiation #2689

Merged
merged 1 commit into from Dec 23, 2020
Merged

Add an integration test for BuildConfig instantiation #2689

merged 1 commit into from Dec 23, 2020

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Dec 22, 2020 •
edited by manusa

We instantiate BuildConfig in Eclipse JKube while doing S2I builds. Adding an integration test for that so that we don't break this again in the future.

Related to #2668

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia marked this pull request as ready for review December 22, 2020 20:08
manusa
manusa requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there is a setup and clean up phase, and that there is a lot of logic here (Watcher implementation, etc.)
It would make more sense to move this to its own test suite (e.g. BuildConfigWatchIT)

@rohanKanojia
Add an integration test for BuildConfig instantiation
39756a1 
We instantiate BuildConfig in Eclipse JKube while doing S2I
builds. Adding an integration test for that so that we don't break this
again in future.

Related to fabric8io#2668
@manusa manusa added this to the 5.0.0 milestone Dec 23, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@manusa
Copy link
Member

manusa commented Dec 23, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 6a717e4 into fabric8io:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rohanKanojia @manusa @oscerd @fusesource-ci