Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Updated and cleaned up Kubernetes + OpenShift examples #2688

Merged
merged 1 commit into from Dec 30, 2020
Merged

doc: Updated and cleaned up Kubernetes + OpenShift examples #2688

merged 1 commit into from Dec 30, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Dec 22, 2020 •
edited

Description

doc: Updated and cleaned up Kubernetes + OpenShift examples

All of the examples (except for PodPresetExamples) have been thoroughly tested.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

Relates to

@manusa manusa added this to the 5.0.0 milestone Dec 22, 2020
@centos-ci
Copy link

Can one of the admins verify this patch?

@manusa manusa mentioned this pull request Dec 22, 2020
Closed
@manusa manusa force-pushed the doc/examples-update branch 2 times, most recently from 740d7c2 to ce3a92c Compare December 23, 2020 11:01
@manusa manusa changed the title wip: Update all examples doc: Updated and cleaned up Kubernetes + OpenShift examples Dec 23, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa marked this pull request as ready for review December 23, 2020 12:17
@manusa
Copy link
Member Author

manusa commented Dec 30, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 5151219 into fabric8io:master Dec 30, 2020
@manusa manusa deleted the doc/examples-update branch December 30, 2020 07:10
@rohanKanojia rohanKanojia mentioned this pull request Jan 11, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@metacosm metacosm Awaiting requested review from metacosm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manusa @centos-ci @rohanKanojia @fusesource-ci