Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Moved KubernetesClient implementation of kubectl run to separa… #2438

Merged
merged 1 commit into from Aug 26, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Aug 25, 2020

Description

fix: Moved KubernetesClient implementation of kubectl run to separate package

Relates to: #2433 #2284

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@manusa
Copy link
Member Author

manusa commented Aug 26, 2020

I was still working on this.

@rohanKanojia
Copy link
Member

ah, sorry. You should have marked it as WIP.

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

73.9% 73.9% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member Author

manusa commented Aug 26, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 1621382 into fabric8io:master Aug 26, 2020
@manusa manusa deleted the fix/clean-run branch August 26, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants