Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2418: CertificateSigningRequest doesn't implement Namespaced #2421

Merged
merged 1 commit into from Aug 24, 2020
Merged

Fix #2418: CertificateSigningRequest doesn't implement Namespaced #2421

merged 1 commit into from Aug 24, 2020

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Aug 21, 2020 •
edited

Fix #2418

  • Add new resources in Cluster scope block in kubernetes model generator
  • Fix previous tests which were wrongly asserting Cluster Scoped resources as Namespaced resources
  • Add dsl entrypoint client.certificateSigningRequests() for dealing with CertificateSigningRequests

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
Fix fabric8io#2418: CertificateSigningRequest doesn't implement Names…
a84ef12 
…paced

+ Add new resources in Cluster scope block in kubernetes model generator
+ Fix previous tests which were wrongly asserting Cluster Scoped resources as Namespaced resources
+ Add dsl entrypoint client.certificateSigningRequests() for dealing with CertificateSigningRequests
@rohanKanojia rohanKanojia removed the wip label Aug 21, 2020
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
7.9% 7.9% Duplication

@manusa
Copy link
Member

manusa commented Aug 24, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 0213db9 into fabric8io:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Create CSR.
4 participants
@rohanKanojia @manusa @oscerd @fusesource-ci