Fix #2321: Add new objects to OpenShift model (with operators.coreos.com and monitoring.coreos.com APIs) #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Aug 19, 2020
rohanKanojia
force-pushed
the
pr/issue2321
branch
from
e07dae6
to
9caf83d
Compare
rohanKanojia
changed the title
rohanKanojia
force-pushed
the
pr/issue2321
branch
from
9caf83d
to
cb11c03
Compare
rohanKanojia
force-pushed
the
pr/issue2321
branch
from
cb11c03
to
010a0ad
Compare
manusa
reviewed
Aug 24, 2020
rohanKanojia
force-pushed
the
pr/issue2321
branch
from
0a418af
to
a44eb18
Compare
manusa
approved these changes
Aug 25, 2020
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
+ Add new OpenShift resources in OpenShift Model as per listed resources in https://docs.openshift.com/container-platform/4.4/rest_api/operator_apis/operator-apis-index.html + Added these new modules in kubernetes-model-generator: - openshift-console-model - openshift-monitoring-model - openshift-operatorhub-model - openshift-operator-model + Added new endpoints in openshift-client DSL: - client.config() - config.openshift.io/v1 - client.operator() - operator.openshift.io/v1 and operator.openshift.io/v1alpha1 - client.operatorHub() - operators.coreos.com/v1alpha1 - client.console() - console.openshift.io/v1 - client.quota() - quota.openshift.io/v1 - client.monitoring() - monitoring.coreosc.com/v1
rohanKanojia
force-pushed
the
pr/issue2321
branch
from
a44eb18
to
e618795
Compare
|
SonarCloud Quality Gate failed.
|
|
[merge] |
1 similar comment
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2321
Add new OpenShift resources(whichever applicable and not colliding with existing resources) in OpenShift Model as per listed
resources in https://docs.openshift.com/container-platform/4.4/rest_api/operator_apis/operator-apis-index.html
Added these new modules in kubernetes-model-generator:
Added new endpoints in openshift-client DSL:
Description
Type of change
test, version modification, documentation, etc.)
Checklist