Fix #2265: Refactor SubjectAccessReview API #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Aug 12, 2020
rohanKanojia
force-pushed
the
pr/issue2265
branch
3 times, most recently
from
a8d52a9
to
f59bbb8
Compare
oscerd
approved these changes
Aug 19, 2020
manusa
reviewed
Aug 20, 2020
kubernetes-client/src/main/java/io/fabric8/kubernetes/client/CreateOnlyResourceOperations.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Aug 20, 2020
...shift-client/src/main/java/io/fabric8/openshift/client/OpenshiftSubjectAccessOperations.java
Outdated
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
pr/issue2265
branch
from
f59bbb8
to
09767fe
Compare
manusa
reviewed
Aug 24, 2020
Comment on lines
39
to
41
| this.subjectAccessApiGroupName = apiGroupName; | ||
| this.subjectAccessApiGroupVersion = apiGroupVersion; | ||
| this.plural = plural; |
There was a problem hiding this comment.
This is redundant, previous statement already takes care of this. I think you can also declare the fields final.
manusa
reviewed
Aug 24, 2020
|
|
||
| public CreateOnlyResourceOperationsImpl(OkHttpClient client, Config config, String apiGroupName, String apiGroupVersion, String plural, Class<T> subjectAccessRequestClass) { | ||
| this(new OperationContext().withOkhttpClient(client).withConfig(config), apiGroupName, apiGroupVersion, plural, subjectAccessRequestClass); | ||
| this.subjectAccessRequestClass = subjectAccessRequestClass; |
There was a problem hiding this comment.
+ Added new entrypoint authorization() into DSL which only allows create() operations + Removed old subjectAccessReviewAuth() API This should also fix fabric8io#2191
TokenReview also are create only resources like SubjectAccess* operations in which same object is returned in response with status object modified. It's support can be added easily with current support added for SubjectAccessReview.
rohanKanojia
force-pushed
the
pr/issue2265
branch
from
09767fe
to
653f98f
Compare
|
SonarCloud Quality Gate failed.
|
manusa
approved these changes
Aug 24, 2020
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2265
This should also fix #2191
Description
Type of change
test, version modification, documentation, etc.)
Checklist