Fix #2354: Fix NullPointerException in ResourceCompare when no resource is returned from fromServer.get() #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Aug 3, 2020
rohanKanojia
force-pushed
the
pr/issue2354
branch
2 times, most recently
from
17aab60
to
dbdcafc
Compare
manusa
approved these changes
Aug 7, 2020
…no resource is returned from fromServer.get() Somehow resource was being returned as `null` from `fromServer.get()` call due to no namespace being provided. Added a case of Null items in `ResourceCompare#equals`
|
Kudos, SonarCloud Quality Gate passed!
|
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2354
Somehow resource was being returned as
nullfromfromServer.get()call due to nonamespace being provided. Added a case of Null items in
ResourceCompare#equalsDescription
Type of change
test, version modification, documentation, etc.)
Checklist