Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2319: Create Config without using auto-configure functionality or setting env variables #2377

Merged
merged 1 commit into from Jul 30, 2020
Merged

Fix #2319: Create Config without using auto-configure functionality or setting env variables #2377

merged 1 commit into from Jul 30, 2020

Conversation

rohanKanojia
Copy link
Member

Fix #2319

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
Copy link
Member Author

This is based on @Fabian-K 's suggestion in the issue here: #2319 (comment)

@rohanKanojia
Copy link
Member Author

@Fabian-K : Could you please review this whenever you find some time?

@Fabian-K
Copy link
Contributor

This looks perfect, thank you!

@rohanKanojia rohanKanojia requested a review from manusa July 30, 2020 07:58
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Jul 30, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 2be0388 into fabric8io:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Config without using auto-configure functionality or setting env variables
5 participants
@rohanKanojia @Fabian-K @manusa @oscerd @fusesource-ci