Fix #2373: Unable to create a Template on OCP3 #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jul 28, 2020
rohanKanojia
force-pushed
the
pr/issue2373
branch
from
1426c0b
to
5789ca2
Compare
manusa
approved these changes
Jul 29, 2020
Looks like code added in fabric8io#1956 BackwardCompatibilityInterceptor wasn't handling /oapi failures properly. Fix BackwardCompatibilityInterceptor logic for routing to OpenShift 3 /oapi/v1 endpoints when OpenShift 4 /apis/{group}/v1 endpoints not found. Also added some tests to assert desired behavior
rohanKanojia
force-pushed
the
pr/issue2373
branch
from
5789ca2
to
293ab9d
Compare
|
SonarCloud Quality Gate failed.
|
|
[merge] |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2373
Looks like code added in #1956 BackwardCompatibilityInterceptor wasn't handling
/oapi`failures properly.Fix BackwardCompatibilityInterceptor logic for routing to OpenShift 3
/oapi/v1endpoints when OpenShift 4
/apis/{group}/v1endpoints not found. Also added sometests to assert desired behavior
Description
Type of change
test, version modification, documentation, etc.)
Checklist