Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update docs in places where POJOs are required. #2369

Merged
merged 1 commit into from Jul 29, 2020

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jul 23, 2020

Since we added Namespaced interface all new CustomResources must
implement this interface in order to be discovered as a Namespaced
entity. Adding this to docs are explicit notes so that they are more
clearly visible.

Related to #2331

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Jul 24, 2020

[merge]

Since we added `Namespaced` interface all new CustomResources must
implement this interface in order to be discovered as a Namespaced
entity. Adding this to docs are explicit notes so that they are more
clearly visible.
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rohanKanojia
Copy link
Member Author

[merge]

@fusesource-ci fusesource-ci merged commit faf669f into fabric8io:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants