Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2287: Add support for V1 and V1Beta1 CustomResourceDefinition #2359

Merged
merged 1 commit into from Jul 24, 2020

Conversation

rohanKanojia
Copy link
Member

Fix #2287

Introduced a new api entrypoint called client.apiextensions() which would
route to apiextensions/v1 and apiextensions/v1beta1 CustomResourceDefinitions

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

…nition

Introduced a new api entrypoint called `client.apiextensions()` which would
route to `apiextensions/v1` and `apiextensions/v1beta1` CustomResourceDefinitions
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 10 Code Smells

80.5% 80.5% Coverage
11.6% 11.6% Duplication

@rohanKanojia rohanKanojia requested a review from manusa July 23, 2020 07:58
@manusa
Copy link
Member

manusa commented Jul 24, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 5db2453 into fabric8io:master Jul 24, 2020
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this pull request Jan 22, 2021
…tions

CustomResourceDefinitions api DSL should not have inNamespace exposed.
This was due to my mistake while adding apiextensions() DSL in
fabric8io#2359
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this pull request Feb 18, 2021
…tions

CustomResourceDefinitions api DSL should not have inNamespace exposed.
This was due to my mistake while adding apiextensions() DSL in
fabric8io#2359
manusa pushed a commit that referenced this pull request Feb 19, 2021
…tions

CustomResourceDefinitions api DSL should not have inNamespace exposed.
This was due to my mistake while adding apiextensions() DSL in
#2359
@manusa manusa added this to the 5.2.0 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CustomResourceDefinitionsOperationsImpl uses v1beta1 API instead of v1
4 participants