Update createOrReplace to work more like BaseOperation

[bbeaudreault]

This fixes #2285

Rather than try to actually handle exception propagation for create-then-replace, I decided to mirror the BaseOperation implementation which does a get then branch accordingly. I added a couple tests.

[centos-ci]

Can one of the admins verify this patch?

[rohanKanojia]

Ok to test

[manusa]

I see the approach of get and then do create / update accordingly if the object exists or not.

I only see one flaw to this approach which is if the object is created (by another thread, process, service, etc.) in the time between get returns null and the current thread/process tries to create the object.

Is it possible to use the try-to-create-or-edit approach by detecting if the POST request failed due to the resource already being there? (I don't know if k8s returns a 409 status or something that will allow us to detect such a case)

Something like:

1. Try to create
   2.A.1. Create works
   2.A.2. Method returns
   2.B.1 Create fails due to conflict
   2.B.2 Try with edit
   2.B......
   2.C.1 Create fails due to some other error
   2.C.2 Throw exception

[bbeaudreault]

I agree, that was my original thought as well, but decided to mirror BaseOperation for uniformity. But I will update to use that approach. We should probably update BaseOperation as well, but I don't have time to do that in this PR right now.

[manusa]

I agree, that was my original thought as well...

Thanks, I created an issue (#2292) to keep track of the change.

[bbeaudreault]

This has been updated as requested

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells

57.1% Coverage
0.0% Duplication

[bbeaudreault]

@rohanKanojia this is ready. can you re-run the 3.11 test?

the remaining 2 code smell seem more trouble than they are worth

[rohanKanojia]

👍 Looks good, Thanks

[manusa]

LGTM, thank you very much!

[rohanKanojia]

[merge]