Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent additionalPrinterColumns jsonPath #4610

Closed
lburgazzoli opened this issue Nov 28, 2022 · 2 comments · Fixed by #4614
Closed

Inconsistent additionalPrinterColumns jsonPath #4610

lburgazzoli opened this issue Nov 28, 2022 · 2 comments · Fixed by #4614
Assignees
Labels
Milestone

Comments

@lburgazzoli
Copy link
Contributor

Describe the bug

I have a class defined like:

@JsonInclude(JsonInclude.Include.NON_NULL)
@Buildable(builderPackage = "io.fabric8.kubernetes.api.builder")
public class DeploymentSpec {

    @PrinterColumn(name = "CONNECTOR_TYPE_ID")
    private String connectorTypeId;
}

And such class is used in bot the spec and the status of a resource.

Fabric8 Kubernetes Client version

5.12.4

Steps to reproduce

Generate CRDs

Expected behavior

The generated CRD should always use the same path to describe the CONNECTOR_TYPE_ID column.
The resulted CRD may get amended at every build, i.e:

image

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3@latest

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

        <kubernetes-client.version>5.12.3</kubernetes-client.version>
        <java-operator-sdk.version>3.1.1</java-operator-sdk.version>
        <quarkus.version>2.11.2.Final</quarkus.version>
        <quarkus-operator-sdk.version>4.0.1</quarkus-operator-sdk.version>
        <sundrio.version>0.50.2</sundrio.version>
@metacosm
Copy link
Collaborator

Note that this probably won't get fixed for 5.12, only for 6.x as new 5.12.x releases are currently not planned.

@lburgazzoli
Copy link
Contributor Author

Note that this probably won't get fixed for 5.12, only for 6.x as new 5.12.x releases are currently not planned.

Not an issue for us

@manusa manusa added the bug label Nov 30, 2022
@manusa manusa added this to the 6.3.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants