File upload unusual behaviour on a ' character

[BrianDevC]

Describe the bug

A file or folder with the single quote ' character in the path name will exhibit unusual behaviour on the upload.

For example if uploading to /data/te'st/file.txt

The following two folders will be created. All square brackets[] added here to emphasize individual folders, they do not show up in the test.

Empty folder:
/[data]/[te'st]/

Folder with empty file.txt
/[data]/[te\st && base64 -d - >]/[data]/[te\st]/file.txt

Fabric8 Kubernetes Client version

5.12.4

Steps to reproduce

String path = "/data/te'st/file.txt";
            client
                    .pods()
                    .withName(podName)
                    .file(path)
                    .upload(inputStream);

Expected behavior

Empty folder:
/data/te'st/

Folder with empty file.txt
/data/te\st && base64 -d - >/data/te\st/file.txt

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.24

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

Looks to be the area that's causing the issue is here:

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java

Line 139 in 0f997aa

static String createExecCommandForUpload(String file) {

Specifically inside the shellQuote function:

  public static String shellQuote(String value) {
    return "'" + value.replace("'", "'\\\\''") + "'";
  }

[shawkins]

Specifically inside the shellQuote function:

Yes, that's unfortunately adding an extra escape. Are you interested in submitting a fix?

[BrianDevC]

I am actually, just pulling everything down to give it a go. Probably should have specified to avoid duplication of efforts!