Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informer initial start exception handling #4408

Closed
shawkins opened this issue Sep 8, 2022 · 0 comments · Fixed by #4488
Closed

Informer initial start exception handling #4408

shawkins opened this issue Sep 8, 2022 · 0 comments · Fixed by #4488
Assignees
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Sep 8, 2022

Is your enhancement related to a problem? Please describe

The startup of an informer is treated differently than exception handling once it is running. On startup any problem with the initial list or watch will be treated as a hard failure, while later on it will keep retrying. See also #4365

Describe the solution you'd like

To conform with the go client we should let the informer simply keep retrying from the start. If the user wants to know if it has ever started, there's the hasSynced method, or we can add another CompletableFuture similar to stopped.

We could apply this change to Informers stated by runnableInformer without much of a risk of compatibility issues. All other paths though the user is probably expecting an informer that has already synced to be returned.

Describe alternatives you've considered

No response

Additional context

No response

@shawkins shawkins added this to the 6.2.0 milestone Sep 8, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 4, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 11, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 11, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 11, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 11, 2022
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant