Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasMetadata.getFullResourceName should provide more information if it fails #4396

Closed
metacosm opened this issue Sep 6, 2022 · 0 comments · Fixed by #4397
Closed

HasMetadata.getFullResourceName should provide more information if it fails #4396

metacosm opened this issue Sep 6, 2022 · 0 comments · Fixed by #4397
Assignees
@metacosm
Labels
enhancement
Milestone
6.2.0

Comments

@metacosm
Copy link
Collaborator

metacosm commented Sep 6, 2022

Is your enhancement related to a problem? Please describe

If you forget to annotate your custom resources with @Group or @Version, calling getFullResourceName will probably fail with an NPE, however not much information is provided about what's wrong and it's not obvious without looking at the code.

Describe the solution you'd like

Just provide more details about why the call failed.

Describe alternatives you've considered

No response

Additional context

No response
@metacosm metacosm self-assigned this Sep 6, 2022
@metacosm metacosm mentioned this issue Sep 6, 2022
Merged
11 tasks
metacosm added a commit that referenced this issue Sep 6, 2022
@metacosm
fix: provide more context when group/plural are missing
a57bde6 
Fixes #4396
@manusa manusa added this to the 6.2.0 milestone Sep 8, 2022
manusa pushed a commit that referenced this issue Sep 8, 2022
@metacosm @manusa
fix: provide more context when group/plural are missing
5d66189 
Fixes #4396
manusa pushed a commit that referenced this issue Sep 8, 2022
@metacosm
fix: provide more context when group/plural are missing (#4397)
e7f6fa3 
* fix: provide more context when group/plural are missing

Fixes #4396

* fix: format

* fix: plural should never be null

* fix: remove NAME constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
enhancement
Projects
None yet
Milestone
6.2.0
Development

Successfully merging a pull request may close this issue.

fix: provide more context when group/plural are missing fabric8io/kubernetes-client
2 participants
@metacosm @manusa