Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extension mock modules #3924

Closed
shawkins opened this issue Mar 3, 2022 · 4 comments · Fixed by #4492
Closed

Remove extension mock modules #3924

shawkins opened this issue Mar 3, 2022 · 4 comments · Fixed by #4492
Assignees
@anurag-rajawat
Labels
component/extensions Deals with the extensions component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly status/never-stale
Milestone
6.2.0

Comments

@shawkins
Copy link
Contributor

shawkins commented Mar 3, 2022 •
edited by manusa

Is your task related to a problem? Please describe

After #3912 the extension mock modules are no longer needed.

Describe the solution you'd like

The user facing classes will have been deprecated, so this issue is a reminder to remove them at a later time - 6.1?

Additional context

The usage of these modules are no longer required since the generic Kubernetes Mock Server can be used instead (is preferred).

  • Extension specific EnableXXXMockClient and XXXMockServer classes have been deprecated. You can simply use EnableKubernetesMockClient and KubernetesMockServer instead. Dependencies on the xxx-mock jar are then no longer needed, just a dependency to kubernetes-server-mock.

kubernetes-client/doc/MIGRATION-v6.md

Line 238 in 43af167

- Extension specific `EnableXXXMockClient` and `XXXMockServer` classes have been deprecated. You can simply use `EnableKubernetesMockClient` and `KubernetesMockServer` instead. Dependencies on the xxx-mock jar are then no longer needed, just a dependency to `kubernetes-server-mock`.

@manusa manusa added this to the 6.x milestone Mar 7, 2022
@manusa manusa added component/extensions Deals with the extensions status/never-stale labels Mar 7, 2022
@anurag-rajawat
Copy link
Contributor

anurag-rajawat commented Mar 12, 2022 •
edited

@shawkins Do we need to remove the <module>mock</module> line from the pom.xml files present in extensions sub-modules or completely remove the mock modules present in the extensions sub-modules?

@shawkins
Copy link
Contributor Author

@anurag-rajawat they should not be removed yet. To ease the migration to 6.0 they will still initially be present but deprecated. In a subsequent release they will be removed.

@shawkins shawkins mentioned this issue Jul 13, 2022
Closed
@manusa manusa added the component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly label Jul 13, 2022
@shawkins shawkins modified the milestones: 6.x, 6.2.0 Sep 30, 2022
@shawkins shawkins modified the milestones: 6.2.0, 6.x Oct 11, 2022
@shawkins
Copy link
Contributor Author

@anurag-rajawat or any other community user interested in picking up an issue, we are ready for this. It is mostly removing the modules, but it will also require cleaning up any tests and examples that still reference them.

@anurag-rajawat
Copy link
Contributor

@shawkins I would love to work on this, assign this to me.
Thanks!

anurag-rajawat added a commit to anurag-rajawat/kubernetes-client that referenced this issue Oct 12, 2022
@anurag-rajawat
fix fabric8io#3924: Remove extension mock modules
a75d30e
anurag-rajawat added a commit to anurag-rajawat/kubernetes-client that referenced this issue Oct 12, 2022
@anurag-rajawat
fix fabric8io#3924: Remove extension mock modules
fa5fe80 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@anurag-rajawat anurag-rajawat mentioned this issue Oct 12, 2022
Merged
11 tasks
anurag-rajawat added a commit to anurag-rajawat/kubernetes-client that referenced this issue Oct 12, 2022
@anurag-rajawat
fix fabric8io#3924: Remove extension mock modules
3a06204 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
anurag-rajawat added a commit to anurag-rajawat/kubernetes-client that referenced this issue Oct 12, 2022
@anurag-rajawat
fix fabric8io#3924: Remove extension mock modules
c8cb3cd 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@manusa manusa modified the milestones: 6.x, 6.2.0 Oct 18, 2022
manusa pushed a commit that referenced this issue Oct 18, 2022
@anurag-rajawat
fix #3924: Remove extension mock modules (#4492)
d7bb757 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>

Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
manusa added a commit that referenced this issue Oct 18, 2022
@manusa
chore: update changelog with deprecation notice from (#3924)
0394a0e 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 6, 2023
@apupier
WIP Camel K 2
9617c21 
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
@apupier apupier mentioned this issue Sep 6, 2023
Merged
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 7, 2023
@apupier
Update to Camel K 2
cdef72a 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 7, 2023
@apupier
Update to Camel K 2
c78a72d 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
3952ea2 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
4e5e8d0 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to camel-tooling/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
217dec0 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 14, 2023
@apupier
Update to Camel K 2
602a732 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anurag-rajawat anurag-rajawat

Labels
component/extensions Deals with the extensions component/kubernetes-server-mock Deals with the kubernetes-server-mock directory mainly status/never-stale
Projects
None yet
Milestone
6.2.0
Development

Successfully merging a pull request may close this issue.

fix #3924: Remove extension mock modules anurag-rajawat/kubernetes-client
3 participants
@manusa @shawkins @anurag-rajawat