Upgrade to Camel K 2 #973
Merged
Upgrade to Camel K 2 #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
force-pushed
the
camelk2
branch
2 times, most recently
from
cdef72a
to
c78a72d
Compare
apupier
commented
Sep 7, 2023
It is impacting mostly the Traits completion/validation * Embed the Camel K CRDs for now. For next iteration, it would nice to: use one from Camel K CRD jar (or another upstream artifact) and then also allow possibility to load from the cluster * Requires to use Jackson Dataformat loader as Snake Yaml one is less permissive and throwing errors * since kubernetes client 6.2.0, no more need of a specific mock dependency fabric8io/kubernetes-client#3924 * No more providing default values as they not yet in CRD apache/camel-k#4726 * Some description are now a lot less precise, adapted tests and reported apache/camel-k#4727 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
djelinek
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is impacting mostly the Traits completion/validation
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
permissive and throwing errors
dependency Remove extension mock modules fabric8io/kubernetes-client#3924
Provide default value in a specific field for trait properties in CRD apache/camel-k#4726
reported Provide full description for trait in CRD apache/camel-k#4727