Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ManagedOpenShiftClient OSGi ConfigurationPolicy to REQUIRE (if applicable) #3864

Closed
manusa opened this issue Feb 15, 2022 · 2 comments · Fixed by #4444
Closed

Change ManagedOpenShiftClient OSGi ConfigurationPolicy to REQUIRE (if applicable) #3864

manusa opened this issue Feb 15, 2022 · 2 comments · Fixed by #4444
Assignees
@rohanKanojia
Labels
status/never-stale

Comments

@manusa
Copy link
Member

manusa commented Feb 15, 2022

This change is for ManagedKubernetes Client (#3700). I am not using OpenShift, and do not have a way to confirm the issue exists there, or to verify any fixes.

Perhaps a separate issue if the ManagedOpenShiftClient is also impacted?

Thanks.

Originally posted by @mattrpav in #3701 (comment)
@stale
Copy link

stale bot commented May 16, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label May 16, 2022
@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Aug 31, 2022
@stale stale bot closed this as completed Sep 7, 2022
@rohanKanojia rohanKanojia reopened this Sep 7, 2022
@stale stale bot removed the status/stale label Sep 7, 2022
@rohanKanojia rohanKanojia self-assigned this Sep 19, 2022
@rohanKanojia rohanKanojia mentioned this issue Sep 19, 2022
Closed
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 23, 2022
@rohanKanojia
fix (openshift-client) : Change ManagedOpenShiftClient OSGi Configura…
7071732 
…tionPolicy to REQUIRE (fabric8io#3864)

Just like ManagedKubernetesClient, ManagedOpenShiftClient also doesn't
handle `activate()` being called with null properties. Setting Component
configuration policy to REQUIRE which would make having configuration
object for ManagedOpenShiftClient (i.e. `src/main/resources/assembly/etc/io.fabric8.openshift.client.cfg`) compulsory.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Sep 23, 2022
Merged
11 tasks
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Sep 23, 2022
@rohanKanojia
fix (openshift-client) : Change ManagedOpenShiftClient OSGi Configura…
7aa186c 
…tionPolicy to REQUIRE (fabric8io#3864)

Just like ManagedKubernetesClient, ManagedOpenShiftClient also doesn't
handle `activate()` being called with null properties. Setting Component
configuration policy to REQUIRE which would make having configuration
object for ManagedOpenShiftClient (i.e. `src/main/resources/assembly/etc/io.fabric8.openshift.client.cfg`) compulsory.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Sep 26, 2022
@rohanKanojia @manusa
fix (openshift-client) : Change ManagedOpenShiftClient OSGi Configura…
2e3194d 
…tionPolicy to REQUIRE (#3864)

Just like ManagedKubernetesClient, ManagedOpenShiftClient also doesn't
handle `activate()` being called with null properties. Setting Component
configuration policy to REQUIRE which would make having configuration
object for ManagedOpenShiftClient (i.e. `src/main/resources/assembly/etc/io.fabric8.openshift.client.cfg`) compulsory.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
status/never-stale
Projects
None yet
Milestone
No milestone
2 participants
@manusa @rohanKanojia