Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesServer JUnit rule ignores value of https when using crud mode #2389

Closed
coopstah13 opened this issue Aug 6, 2020 · 1 comment
Closed
Labels

Comments

@coopstah13
Copy link
Contributor

See here

  public void before() {
    mock = crudMode
      ? new KubernetesMockServer(new Context(), new MockWebServer(), new HashMap<ServerRequest, Queue<ServerResponse>>(), new KubernetesCrudDispatcher(), true)
      : new KubernetesMockServer(https);
    mock.init();
    client = mock.createClient();
  }

When constructing a KubernetesServer JUnit rule you can specify a value for crudMode and https, but if you specify crudMode=true then the value for https is not used when creating the KubernetesMockServer so it will always be https enabled.

coopstah13 pushed a commit to coopstah13/kubernetes-client that referenced this issue Aug 6, 2020
When using the KubernetesServer JUnit rule in crud mode the KubernetesMockServer is using a hardcoded value of true for https instead of using the value of https provided to the JUnit rule.
coopstah13 pushed a commit to coopstah13/kubernetes-client that referenced this issue Aug 6, 2020
When using the KubernetesServer JUnit rule in crud mode the KubernetesMockServer is using a hardcoded value of true for https instead of using the value of https provided to the JUnit rule.
@manusa manusa added the bug label Aug 18, 2020
@rohanKanojia
Copy link
Member

Closed via #2390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants