fabric8io#2389: Use https value with crud mode in KubernetesServer

When using the KubernetesServer JUnit rule in crud mode the KubernetesMockServer is using a hardcoded value of true for https instead of using the value of https provided to the JUnit rule.
coopstah13 · Aug 6, 2020 · f3d08cc · f3d08cc
1 parent 50c1e8d
commit f3d08cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 #### Bugs
 * Fix #2373: Unable to create a Template on OCP3
 * Fix #2316: Cannot load resource from stream without apiVersion
+* Fix #2389: KubernetesServer does not use value from https in crud mode
 
 #### Improvements
 * Fix #2331: Fixed documentation for namespaced informer for all custom types implementing `Namespaced` interface

diff --git a/...-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesServer.java b/...-server-mock/src/main/java/io/fabric8/kubernetes/client/server/mock/KubernetesServer.java
@@ -53,7 +53,7 @@ public KubernetesServer(boolean https, boolean crudMode) {
 
   public void before() {
     mock = crudMode
-      ? new KubernetesMockServer(new Context(), new MockWebServer(), new HashMap<ServerRequest, Queue<ServerResponse>>(), new KubernetesCrudDispatcher(), true)
+      ? new KubernetesMockServer(new Context(), new MockWebServer(), new HashMap<ServerRequest, Queue<ServerResponse>>(), new KubernetesCrudDispatcher(), https)
       : new KubernetesMockServer(https);
     mock.init();
     client = mock.createClient();