Skip to content

Commit

Permalink
fix (osgi): Add Provide-Capability field in extension bundle configur…
Browse files Browse the repository at this point in the history
…ations

+ Add Provide-Capability field in openshift-client + extensions bundle
configurations in order to resolve SPIFly related NPE (reported in #3890)

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
  • Loading branch information
rohanKanojia authored and manusa committed Oct 5, 2022
1 parent 21b5014 commit e899d91
Show file tree
Hide file tree
Showing 16 changed files with 73 additions and 0 deletions.
4 changes: 4 additions & 0 deletions extensions/camel-k/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.camelk.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/certmanager/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.certmanager.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/chaosmesh/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.chaosmesh.client.*,
Expand Down
8 changes: 8 additions & 0 deletions extensions/istio/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@
<name>Fabric8 :: Istio :: Client</name>

<properties>
<osgi.require-capability>
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.istio.client.*,
Expand Down
8 changes: 8 additions & 0 deletions extensions/knative/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@
<name>Fabric8 :: Knative :: Client</name>

<properties>
<osgi.require-capability>
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.knative.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/open-cluster-management/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.openclustermanagement.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/service-catalog/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.servicecatalog.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/tekton/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.tekton.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/verticalpodautoscaler/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.verticalpodautoscaler.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/volcano/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.volcano.client.*,
Expand Down
4 changes: 4 additions & 0 deletions extensions/volumesnapshot/client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter
</osgi.provide-capability>
<osgi.import>
io.fabric8.kubernetes.api.builder,
!io.fabric8.volumesnapshot.client.*,
Expand Down
4 changes: 4 additions & 0 deletions httpclient-jdk/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)",
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.http.HttpClient$Factory
</osgi.provide-capability>
<osgi.import>
!android.util*,
*,
Expand Down
4 changes: 4 additions & 0 deletions httpclient-jetty/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)",
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.http.HttpClient$Factory
</osgi.provide-capability>
<osgi.import>
!android.util*,
*,
Expand Down
4 changes: 4 additions & 0 deletions httpclient-okhttp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)",
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.http.HttpClient$Factory
</osgi.provide-capability>
<osgi.import>
!android.util*,
*,
Expand Down
4 changes: 4 additions & 0 deletions kubernetes-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.processor)",
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.ServiceToURLProvider
</osgi.provide-capability>
<osgi.import>
!android.util*,
*,
Expand Down
5 changes: 5 additions & 0 deletions openshift-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
osgi.extender;
filter:="(osgi.extender=osgi.serviceloader.registrar)"
</osgi.require-capability>
<osgi.provide-capability>
osgi.serviceloader;
osgi.serviceloader=io.fabric8.kubernetes.client.extension.ExtensionAdapter,
io.fabric8.kubernetes.client.ServiceToURLProvider
</osgi.provide-capability>
<osgi.import>
!org.junit*,
*
Expand Down

0 comments on commit e899d91

Please sign in to comment.