Skip to content

Commit

Permalink
fix (osgi): Remove ExtensionAdapter reference from ManagedKubernetesC…
Browse files Browse the repository at this point in the history
…lient

Remove ExtensionAdapter reference from ManagedKubernetesClient, no
provider is exposed for ExtensionAdapter interface in
kubernetes-client module. bindExtensionAdapter and
unbindExtensionAdapter are throwing NullPointerException during
startup.
  • Loading branch information
manusa committed Oct 5, 2022
1 parent 49e8f16 commit 818ca2d
Showing 1 changed file with 0 additions and 10 deletions.
Expand Up @@ -21,7 +21,6 @@
import io.fabric8.kubernetes.client.NamespacedKubernetesClient;
import io.fabric8.kubernetes.client.OAuthTokenProvider;
import io.fabric8.kubernetes.client.ResourceHandler;
import io.fabric8.kubernetes.client.extension.ExtensionAdapter;
import org.apache.felix.scr.annotations.Activate;
import org.apache.felix.scr.annotations.Component;
import org.apache.felix.scr.annotations.ConfigurationPolicy;
Expand Down Expand Up @@ -66,7 +65,6 @@
@Service({ KubernetesClient.class, NamespacedKubernetesClient.class })
@References({
@Reference(referenceInterface = io.fabric8.kubernetes.client.ResourceHandler.class, cardinality = ReferenceCardinality.OPTIONAL_MULTIPLE, policy = ReferencePolicy.DYNAMIC, bind = "bindResourceHandler", unbind = "unbindResourceHandler"),
@Reference(referenceInterface = ExtensionAdapter.class, cardinality = ReferenceCardinality.OPTIONAL_MULTIPLE, policy = ReferencePolicy.DYNAMIC, bind = "bindExtensionAdapter", unbind = "unbindExtensionAdapter"),
@Reference(referenceInterface = OAuthTokenProvider.class, cardinality = ReferenceCardinality.OPTIONAL_UNARY, policyOption = ReferencePolicyOption.GREEDY, bind = "bindOAuthTokenProvider", unbind = "unbindOAuthTokenProvider")
})
public class ManagedKubernetesClient extends NamespacedKubernetesClientAdapter<DefaultKubernetesClient> {
Expand Down Expand Up @@ -191,14 +189,6 @@ public void unbindResourceHandler(ResourceHandler resourceHandler) {
// not used
}

public void bindExtensionAdapter(ExtensionAdapter adapter) {
getClient().getAdapters().register(adapter);
}

public void unbindExtensionAdapter(ExtensionAdapter adapter) {
getClient().getAdapters().unregister(adapter);
}

public void bindOAuthTokenProvider(OAuthTokenProvider provider) {
this.provider = provider;
}
Expand Down

0 comments on commit 818ca2d

Please sign in to comment.