fix #228. Don't report cache miss if skipping namespace metadata

fabric8io · Jan 22, 2021 · 7ba2d62 · 7ba2d62
1 parent 4bb52f5
commit 7ba2d62
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/fluent/plugin/kubernetes_metadata_cache_strategy.rb b/lib/fluent/plugin/kubernetes_metadata_cache_strategy.rb
@@ -30,8 +30,10 @@ def get_pod_metadata(key, namespace_name, pod_name, record_create_time, batch_mi
           (m.nil? || m.empty?) ? {'pod_id'=>ids[:pod_id]} : m
         end
         metadata.merge!(@namespace_cache.fetch(ids[:namespace_id]) do
-          @stats.bump(:namespace_cache_miss)
-          m = fetch_namespace_metadata(namespace_name) unless @skip_namespace_metadata
+          m = unless @skip_namespace_metadata
+            @stats.bump(:namespace_cache_miss)
+            fetch_namespace_metadata(namespace_name) 
+          end
           (m.nil? || m.empty?) ?  {'namespace_id'=>ids[:namespace_id]} : m
         end)
       else