Adds missing dash to --build-arg #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
approved these changes
May 24, 2022
|
@chonton : Could you please review this whenever you get time? |
|
looks good. how about a unit test? |
According to the help-output of `docker buildx build --help`:
```
Usage: docker buildx build [OPTIONS] PATH | URL | -
[...]
Options:
--add-host strings Add a custom host-to-IP mapping (format: "host:ip")
--allow strings Allow extra privileged entitlement (e.g., "network.host", "security.insecure")
--build-arg stringArray Set build-time variables
[...]
```
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
============================================
+ Coverage 62.65% 62.70% +0.05%
- Complexity 2141 2143 +2
============================================
Files 170 170
Lines 9886 9886
Branches 1355 1355
============================================
+ Hits 6194 6199 +5
+ Misses 3176 3172 -4
+ Partials 516 515 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the help-output of
docker buildx build --help: