Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replacements in build <tags> #1491

Merged
merged 2 commits into from Sep 24, 2021
Merged

Allow replacements in build <tags> #1491

merged 2 commits into from Sep 24, 2021

Conversation

Xyaren
Copy link
Contributor

@Xyaren Xyaren commented Sep 16, 2021

Fixes #1367
Allows replacement in tags and added a new replacement %T which always adds a timestamp, independent of the version.

Fixes #1367

Signed-off-by: Tobias Günther <Xyaren@users.noreply.github.com>
@rohanKanojia
Copy link
Member

@Xyaren: Thanks a lot for your PR 👍 . Could you please add a line to doc/changelog.md regarding this change?

@Xyaren
Copy link
Contributor Author

Xyaren commented Sep 17, 2021

@Xyaren: Thanks a lot for your PR 👍 . Could you please add a line to doc/changelog.md regarding this change?

You're welcome.
Added the entry :)

@Xyaren
Copy link
Contributor Author

Xyaren commented Sep 20, 2021

What's the process of getting this to a new version ?
I can still see a circleci as "Expected" since 2 days.

@rohanKanojia
Copy link
Member

@Xyaren: Are you asking for a new release?

@rohanKanojia
Copy link
Member

Thanks a lot!

@rohanKanojia rohanKanojia merged commit 3118642 into fabric8io:master Sep 24, 2021
@Xyaren
Copy link
Contributor Author

Xyaren commented Nov 8, 2021

Is there any chance, that this is releases soon ?

@rohanKanojia
Copy link
Member

Yes, let me cut a release tonight. I'll notify you whenever it's available.

@Xyaren
Copy link
Contributor Author

Xyaren commented Nov 8, 2021

Awsome thank you :)

@rohanKanojia
Copy link
Member

@Xyaren : https://repo1.maven.org/maven2/io/fabric8/docker-maven-plugin/0.38.0/

Would appreciate if you could test with the release and provide feedback if it's working okay with new version now 🙏

@Xyaren
Copy link
Contributor Author

Xyaren commented Nov 9, 2021

Working fine :) Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply replacements to additional tags in: tags/tag
2 participants