inconsistent names of the entryPoint configuration parameter

[energister]

maven 3.6.3 error:

Unable to parse configuration of mojo io.fabric8:docker-maven-plugin:0.37.0:start for parameter entryPoint: Cannot find 'entryPoint' in class io.fabric8.maven.docker.config.RunImageConfiguration

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[rohanKanojia]

I guess this is due to entrypoint field present in both BuildImageConfiguration <build> and RunImageConfiguration <run>. It's named differently at both places:

BuildImageConfiguration:

docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/BuildImageConfiguration.java

Line 148 in 7d23d73

private Arguments entryPoint;

RunImageConfiguration:

docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/RunImageConfiguration.java

Line 52 in 7d23d73

private Arguments entrypoint;

[energister]

So should I rename the property in RunImageConfiguration instead of changing documentation to make settings names consistent?

[rhuss]

+1 for making the naming of the fields consistent in the code and name it entryPoint but also keep the entrypoint but deprecate it (like we did here

docker-maven-plugin/src/main/java/io/fabric8/maven/docker/config/BuildImageConfiguration.java

Lines 119 to 124 in 7d23d73

	@Deprecated
	@Parameter
	private Boolean nocache;
	@Parameter
	private Boolean noCache;

for noCache, a similar issue)

For the document I would only use entryPoint though, but keeping entrypoint helps for backwards compatibility. Don't forget to mention it in the changelog, too.

thanks !

[codecov]

Codecov Report

Merging #1488 (0387f4d) into master (d4f1584) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1488      +/-   ##
============================================
- Coverage     62.13%   62.12%   -0.01%     
- Complexity     2173     2174       +1     
============================================
  Files           166      166              
  Lines          9554     9559       +5     
  Branches       1441     1442       +1     
============================================
+ Hits           5936     5939       +3     
- Misses         3107     3108       +1     
- Partials        511      512       +1     

Impacted Files	Coverage Δ
...ic8/maven/docker/config/RunImageConfiguration.java	90.75% <66.66%> (-0.92%)	⬇️

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

77.8% Coverage
0.0% Duplication