Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to dump the logs to an output file #1472

Merged
merged 4 commits into from May 19, 2021

Conversation

andreaTP
Copy link
Member

This option is designed after:
https://maven.apache.org/plugins/maven-dependency-plugin/list-mojo.html#outputFile

Basically, it redirects the output logs to a file that can be processed by something else (another Mojo, external tools, etc.)

For context:
I'm working on Maven plugin that needs(in this case) to extract the pushed image sha.

@rohanKanojia
Copy link
Member

There seem to be some test failures. Could you please address them?

@andreaTP
Copy link
Member Author

Hey @rohanKanojia good to see you here 🙂 !
I should have fixed the tests now.

@andreaTP
Copy link
Member Author

Sonar is failing with:

Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.0.2155:sonar (default-cli) on project docker-maven-plugin: You're not authorized to run analysis. Please contact the project administrator.

probably because the PR is from a fork, not sure how to fix it, any guidance?

@rohanKanojia
Copy link
Member

Don't worry about it. We had removed secrets and disabled sonarcube integration due to recent Codecov vulnerability. We'll revisit it again in future.

@rohanKanojia rohanKanojia self-requested a review May 12, 2021 13:36
@andreaTP
Copy link
Member Author

@rohanKanojia have you had the chance to review this PR? Anything I can do to give more context or any additional explanation?
Sorry for asking, but I'm building quite some code/builds on top of this:
https://github.com/lightbend/cloudflow/pull/1049/files

The plugin itself is amazing and I really enjoy it!
Thanks a lot in advance!

@rohanKanojia
Copy link
Member

rohanKanojia commented May 13, 2021

Sorry for delay, I'll review your PR this weekend. You'll need a release after merging this change too?

@andreaTP
Copy link
Member Author

Truly appreciated @rohanKanojia !
Yes, I would need a release of the plugin, I'm building on top of it:

https://github.com/lightbend/cloudflow/pull/1049/files#diff-5c8dd2c16e0716fc062f33c1e549d561efc917f75fb9f52268cb7059d7358609R36

@andreaTP
Copy link
Member Author

@rohanKanojia ready for next review round 🙂

@rohanKanojia
Copy link
Member

Could you please add a line to doc/changelog regarding this feature as well? It looks good to be merged 👍

@andreaTP
Copy link
Member Author

@rohanKanojia added an entry to the changelog and rebased on latest master, thanks for bearing with me!

@rohanKanojia rohanKanojia merged commit ee65068 into fabric8io:master May 19, 2021
@andreaTP
Copy link
Member Author

Thanks! Do you have any ETA for the release?

@rohanKanojia
Copy link
Member

I will try to cut a release this weekend. Could you please test against master SNAPSHOT build to check everything is working as expected with your project?

@andreaTP
Copy link
Member Author

I can confirm that everything works as expected in my project thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants