Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race condition when creating port bindings #1447

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Avoid race condition when creating port bindings #1447

merged 2 commits into from
Apr 1, 2021

Commits on Mar 31, 2021

  1. Avoid race condition when creating port bindings 

    On container startup, sometimes the port information retrieved from the
docker API is incomplete with port details being empty arrays, e.g.
Ports:{"2525/tcp":[]}. This causes an IndexOutOfBoundsException to be thrown
as the createPortBindings method assumes there will be at least one entry in
the mapping. In these cases we should retry the API call to get the more
complete port information.

Signed-off-by: Ewen Cluley <ewen@brandwatch.com>
    @ewencluley
    ewencluley committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    2f2cb0a View commit details
    Browse the repository at this point in the history

  2. Use exponential backoff when retrying from 10ms to 100ms

    @ewencluley
    ewencluley committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    4b7c1ef View commit details
    Browse the repository at this point in the history