Fix #1082 where assembly.inline is removed when external properties are enabled
#1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caitlinelfring
changed the title
assembly.inline is removed when external properties are enabledassembly.inline is removed when external properties are enabled
caitlinelfring
force-pushed
the
assembly-inline-properties-fix
branch
from
225d20e
to
af25d1b
Compare
|
I'm not sure why CI build isn't running? I see it's worked on other PRs opened recently. |
caitlinelfring
force-pushed
the
assembly-inline-properties-fix
branch
from
d320401
to
04ff4d7
Compare
rohanKanojia
force-pushed
the
assembly-inline-properties-fix
branch
from
04ff4d7
to
31a16eb
Compare
|
I've rebased your PR against master. Seems like CI checks are running now... |
Codecov Report
@@ Coverage Diff @@
## master #1434 +/- ##
============================================
+ Coverage 58.08% 58.23% +0.14%
- Complexity 1939 1955 +16
============================================
Files 162 162
Lines 9013 9014 +1
Branches 1361 1362 +1
============================================
+ Hits 5235 5249 +14
+ Misses 3300 3295 -5
+ Partials 478 470 -8
|
Add test to show `assembly.inline` is removed when external properties are enabled Signed-off-by: Caitlin Elfring <celfring@gmail.com>
rohanKanojia
force-pushed
the
assembly-inline-properties-fix
branch
from
31a16eb
to
a324a4d
Compare
rohanKanojia
approved these changes
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1082 and fixes #1356
This is based on the solution provided in #1082. I also added a test to show that the solution fixes the issue.