Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set SHELL from build config #1419

Merged
merged 4 commits into from
Mar 7, 2021

Conversation

omyl
Copy link
Contributor

@omyl omyl commented Dec 7, 2020

resolve #1418

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1419 (dc05233) into master (2534a55) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1419      +/-   ##
============================================
- Coverage     58.23%   57.69%   -0.54%     
+ Complexity     1955     1916      -39     
============================================
  Files           162      161       -1     
  Lines          9014     9007       -7     
  Branches       1362     1359       -3     
============================================
- Hits           5249     5197      -52     
- Misses         3295     3335      +40     
- Partials        470      475       +5     
Impacted Files Coverage Δ Complexity Δ
...8/maven/docker/assembly/DockerAssemblyManager.java 17.12% <100.00%> (+0.32%) 11.00 <0.00> (ø)
...ven/docker/access/hc/ApacheHttpClientDelegate.java 10.60% <0.00%> (-47.37%) 0.00% <0.00%> (-17.00%)
...ic8/maven/docker/config/AssemblyConfiguration.java 75.38% <0.00%> (-4.62%) 14.00% <0.00%> (-5.00%)
...config/handler/property/PropertyConfigHandler.java 76.56% <0.00%> (-4.27%) 124.00% <0.00%> (-11.00%)
...ker/access/hc/HcChunkedResponseHandlerWrapper.java
...ven/docker/access/hc/DockerAccessWithHcClient.java 25.55% <0.00%> (+0.34%) 26.00% <0.00%> (ø%)

@rhuss
Copy link
Collaborator

rhuss commented Mar 7, 2021

Thanks ! I added a unit test + chagnelog entry, could please open up your branch so that I could push to it (and we then can merge it after this)

@omyl
Copy link
Contributor Author

omyl commented Mar 7, 2021

... could please open up your branch so that I could push to it (and we then can merge it after this) ....
@rhuss - hope its done (unfortunatelly i'm still not familiar with github :-/)

@rhuss
Copy link
Collaborator

rhuss commented Mar 7, 2021

nope, doesn't work yet. You need to enable the checkbox on the right column in the GitHub UI when looking at the PR. It should look like:

image

@rhuss
Copy link
Collaborator

rhuss commented Mar 7, 2021

sorry my bad. works now.

@rhuss rhuss merged commit ceb143f into fabric8io:master Mar 7, 2021
@omyl omyl deleted the feature/allowshellfromconfig branch February 3, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow specify SHELL by plugin build configuration
2 participants