-
Notifications
You must be signed in to change notification settings - Fork 649
Support for JIB(Java Image Builder) mode in dmp #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ce5eac
to
c4af0d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @rohanKanojia ! That's awesome ;-)
Unfortunately I'm on the road this week, so probably can't review it this week.
One thing I remarked is that docker:build
with JIB pushes to a registry like docker:push
would do. I know that's how JIB works normally, but maybe we can still keep that phases seperate ? I.e. docker:build would create the tar file only and docker:push would move it to the registry ?
@rhuss : Yes, I think this is possible and I would also like to have behavior like this. JIB has an offline mode; we can force offline mode during build phase and regular build during push phase. |
c4af0d5
to
7e6e53b
Compare
@rohanKanojia Thanks a lot, looks good ! Let me integrate it until the end of the week, when I'm back from the conference. |
This has some problems, marking as WIP until update. |
@rohanKanojia ok, let me know when its ready for review. |
7e6e53b
to
d2c7054
Compare
Actually, we faced some issue on fmp for this jib, jibservice wasn't considering some parameters of ImageConfiguration . I have refactored code a bit to handle those cases(for ex, when you want to push a registry other than docker hub). But you're the expert here, you can put more light on what other use cases are still missing during code review. |
I will review this PR after the next release. But let's get out a version of dmp first, as it already contains a tons of new stuff. |
@rohanKanojia sorry for the delay, but could you rebase this and fix the conflicts ? Let's get this in for the next release ... |
d2c7054
to
3dec1c7
Compare
This ports Jib support added in https://github.com/eclipse/jkube
3dec1c7
to
676cfba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Looks good to me on a quick review. Let's merge the PR now and we always can refine it later if needed.
This ports Jib support added in Eclipse JKube in eclipse-jkube/jkube#257