Support TimeOnly, DateOnly

[kerams]

Implements #2519.

TimeOnly is represented by a simple number, just like TimeSpan. DateOnly is represented by Date like DateTime.

Remaining work

• Tests that comparison, hashing (dictionary lookup) works for both types
• TimeOnly subtraction operator
• TimeOnly.(Try)Parse
• DateOnly.ToString
• DateOnly.(Try)Parse
• DateOnly.Add(Days|Months|Years)
• DateOnly.ToDateTime

Not implementing

• DateOnly has a constructor which lets you specify the calendar used to intepret the other parameters. This would add another layer of complexity, and I don't think it's of any interest to the vast majority of users.
• DateOnly.ToLongDateString, DateOnly.ToShortDateString, TimeOnly.ToLongTimeString, TimeOnly.ToShortTimeString. You can just use ToString with the corresponding format specifier.
• DateOnly.ToString formats D, r, R, m, M, y, Y because they produce localized text.
• (Try)ParseExact on both types

[alfonsogarciacaro]

Great work @kerams, thank you! Please just let me know when this is ready to merge 👍

[kerams]

For some reason .NET SDK 5.0.403 was used for the last build, hence the failing tests.

[kerams]

Ah, you changed the workflow file today. Well, without .NET 6 we're not going to get liftoff here :).

[alfonsogarciacaro]

Sorry, we had some issues when updating to F# 6 (see #2605) but hopefully they're solved now, can you try syncing with main. Thanks!

[kerams]

@alfonsogarciacaro, I'm not sure what's going on. The new tests pass the first time around, but then do not get compiled as .NET 6 following /home/runner/work/Fable/Fable> node ./src/fable-compiler-js/src/app.fs.js tests/Main/Fable.Tests.fsproj build/tests-js. I've switched fable-compiler-js.fsproj to .NET 6, but it didn't help.

I don't think that part of the test suite had been run when I got green ticks previously.

[alfonsogarciacaro]

@kerams Sorry, I should have explained this to you before. Fable standalone packs its own BCL DLLs because the point is dotnet/nuget doesn't need to be installed in the system (or the browser). These DLLs are in fable-metadata and are generated by custom build of FCS by (you probably guessed it) @ncave. We haven't updated the DLLs to net6 yet so that explains why fable-standalone doesn't find the new classes

We can update the DLLs but maybe it's better to do it when @ncave updates fcs-fable... Yet another fork to make FCS compilable by Fable :) So for now we can disable them for fable-compiler-js. I can do that so you don't need to worry.

Thanks again for this work!

[kerams]

Alright then, thanks.

[ncave]

@alfonsogarciacaro I've updated the BCL to 6.0.100 in #2612, hopefully that works.

[alfonsogarciacaro]

Thank you both! Released in v3.6.0-beta-001 👍