Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert FSharp/FSharpSet #2187

Merged
merged 1 commit into from Sep 30, 2020
Merged

Revert FSharp/FSharpSet #2187

merged 1 commit into from Sep 30, 2020

Conversation

alfonsogarciacaro
Copy link
Member

@alfonsogarciacaro alfonsogarciacaro mentioned this pull request Sep 30, 2020
Merged
@ncave
Copy link
Collaborator

ncave commented Sep 30, 2020 •
edited

@alfonsogarciacaro Please retarget the branch when you can. Can we keep the new implementations as a PR so we can work on improving their performance?

@alfonsogarciacaro alfonsogarciacaro changed the base branch from master to nagareyama September 30, 2020 10:58
@alfonsogarciacaro
Copy link
Member Author

This is happening too often, sorry! I will make nagareyama the default branch.

@alfonsogarciacaro alfonsogarciacaro merged commit 09642fd into nagareyama Sep 30, 2020
@alfonsogarciacaro
Copy link
Member Author

Can we keep the new implementations as a PR so we can work on improving their performance?

Done! See #2188. I will remove Reflection_typeTest in a separate PR and we can test again the performance when merged 👍

@alfonsogarciacaro alfonsogarciacaro deleted the nagareyama-revert-map-set branch October 1, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alfonsogarciacaro @ncave