Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Require Symfony 3.4.24 in order to drop overloaded RedisTrait #6

Merged
merged 1 commit into from Apr 4, 2019
Merged

[Cleanup] Require Symfony 3.4.24 in order to drop overloaded RedisTrait #6

merged 1 commit into from Apr 4, 2019

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Apr 3, 2019 •
edited

… & connected RedisClusterProxy

It was overloaded due to symfony/symfony#30518

@andrerom andrerom requested a review from kmadejski April 3, 2019 06:56
kmadejski
kmadejski approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@kmadejski kmadejski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that you've managed to get rid of these two big files! Maintenance will be much easier in the future 🙂

@andrerom andrerom merged commit eff67ac into master Apr 4, 2019
@andrerom andrerom deleted the bump_symfony branch April 4, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmadejski kmadejski kmadejski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@andrerom @kmadejski