[Git] Drop most test files & unsupported features from builds to reduce size #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Reduce Size of install in order to enable use on setups such as AWS Lambda. Tested using "git archive --prefix=test/ -o test.zip HEAD": - 7.5: 5.9mb compressed, 41.6mb extracted - this: 3.7mb compressed, 22.8mb extracted Todo: - Test against SolrBundle - Get Netgen to test their packages that rely on kernel test classes
andrerom
changed the title
andrerom
changed the title
alongosz
requested changes
Sep 30, 2019
alongosz
approved these changes
Sep 30, 2019
andrerom
changed the title
|
@andrerom I know that at least Tags Bundle uses test classes and fixtures from kernel. This can probably be remedied by using source as the preferred install. |
|
Agree: any downstream that needs Test stuff from Kernel should be able to set up composer to do a Source install in order to get all the goodies |
|
ok, I'll look into the todos here and wrap this up if any changes are needed. Thanks for the feedback so far! 🗣 If anyone sees this differently, please let us know! |
andrerom
changed the title
|
Finally got around to test archive from this on solr bundle, it fails on first test with: @alongosz and @adamwojs Should we keep this for master only maybe? Or do we assume stable packages like solr fetches kernel from dev/source always? |
@andrerom the fact that test setup from Solr relies on test setup from Kernel is a mistake. Usually those namespaces are Though, I'm not following how the mentioned failure is related to reduced build. Are some classes missing which results in |
|
Actually I'm not entirely sure. Might actually be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops most tests and unsupported features (old broken elasticsearch 1.5 search prototype, this is removed in master and will likely come re-written next year as new package instead).
Main motivation:
A step to reduce size of install in order to in the end enable use on setups such as AWS Lambda. Same as done for Symfony 4.4 recently here: symfony/symfony#33579
Size change:
Tested using
git archive --prefix=test/ -o test.zip HEADCommunity bundles that relies on Test classes and fixtures in kernel will for testing have to force Composer to install using sources instead of tags (
--prefer-source), at least for this package.Todo: