Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30675: Replaced deprecated PHPUnit asserts with proper ones #2669

Merged
merged 3 commits into from Jun 19, 2019
Merged

EZP-30675: Replaced deprecated PHPUnit asserts with proper ones #2669

merged 3 commits into from Jun 19, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jun 18, 2019 •
edited

Question Answer
JIRA issue EZP-30675
Improvement yes
New feature no
Target version master
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk self-assigned this Jun 18, 2019
@mikadamczyk mikadamczyk changed the title Change deprecated assertions Change and remove deprecated assertions Jun 18, 2019
@alongosz alongosz force-pushed the test-symfony4-dedicate-assert branch from e5a004d to d12b3f9 Compare June 18, 2019 15:08
@alongosz alongosz changed the title Change and remove deprecated assertions Replaced deprecated PHPUnit asserts with proper ones Jun 18, 2019
@alongosz alongosz force-pushed the test-symfony4-dedicate-assert branch from d12b3f9 to 7bfb329 Compare June 18, 2019 15:10
@alongosz alongosz changed the title Replaced deprecated PHPUnit asserts with proper ones EZP-30675: Replaced deprecated PHPUnit asserts with proper ones Jun 19, 2019
@alongosz alongosz merged commit 322f11c into ezsystems:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom left review comments

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

@pawbuj pawbuj Awaiting requested review from pawbuj

@ViniTou ViniTou Awaiting requested review from ViniTou

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@mikadamczyk mikadamczyk

Labels
Improvement Ready for MERGE
Milestone
No milestone
4 participants
@mikadamczyk @adamwojs @andrerom @alongosz