Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed getSchemaFiles & getFixtures methods in IbexaTestKernel #284

Merged
merged 2 commits into from Feb 10, 2022

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Feb 8, 2022

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v3.3
BC breaks no

This PR is extracted from #242.

It exposes getSchemaFiles and getFixtures as methods in IbexaTestKernel, so that bootstrapping scripts can make use of these.

Previously the only location these were available were IbexaKernelTestCase, which meant that they were only accessible during test execution itself.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@Steveb-p Steveb-p changed the title Expose getSchemaFiles & getFixtures methods in IbexaTestKernel Exposed getSchemaFiles & getFixtures methods in IbexaTestKernel Feb 8, 2022
@Steveb-p Steveb-p requested review from alongosz, adamwojs and a team February 8, 2022 13:48
@Steveb-p Steveb-p added Improvement Changes not fixing or changing behavior Ready for review labels Feb 8, 2022
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Steveb-p CI is failing here

@Steveb-p
Copy link
Contributor Author

Steveb-p commented Feb 8, 2022

@Steveb-p CI is failing here

Fixed. Apparently it's a new "feature" in php-cs-fixer 3.6.0.

minor PHP-CS-Fixer/PHP-CS-Fixer#6199 HeaderCommentFixer - support monolithic files with shebang (kubawerlos, keradus)

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p Steveb-p merged commit cdf5312 into 1.3 Feb 10, 2022
@Steveb-p Steveb-p deleted the expose-schema-fixtures branch February 10, 2022 10:28
@Steveb-p
Copy link
Contributor Author

Merged into main in 6d60013a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes not fixing or changing behavior Ready for review
7 participants