Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Language::$id phpdoc being not accurate #281

Merged
merged 1 commit into from Jan 14, 2022
Merged

Fixed Language::$id phpdoc being not accurate #281

merged 1 commit into from Jan 14, 2022

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue N/A
Type improvement
Target Ibexa version v3.3
BC breaks no

Changes PHPDoc for SPI Language to be more accurate.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@Steveb-p Steveb-p requested a review from a team January 14, 2022 17:56
@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p
Copy link
Contributor Author

Steveb-p commented Jan 14, 2022 •
edited

Code style error is unrelated and will be fixed separately (or a patch comes for php-cs-fixer, which will make it obsolete).

It comes from a regression introduced in the newest php-cs-fixer (3.5.0): PHP-CS-Fixer/PHP-CS-Fixer#6238.

@Steveb-p Steveb-p merged commit 31a645f into 1.3 Jan 14, 2022
@Steveb-p Steveb-p deleted the fix-language-spi-phpdoc branch January 14, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@damianz5 damianz5 damianz5 approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees
No one assigned
Labels
Ready for review
Milestone
No milestone
5 participants
@Steveb-p @lserwatka @adamwojs @damianz5 @konradoboza