Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32404: Return correct type for DBAL 2.13 #174

Closed
wants to merge 1 commit into from

Conversation

wizhippo
Copy link
Contributor

@wizhippo wizhippo commented Apr 1, 2021

Question Answer
JIRA issue EZP-32404
Type bug
Target eZ Platform version v3.3
BC breaks no
Doc needed no

QueryBuilder returns a ResultStatement since DBAL 2.10.2

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

QueryBuilder returns a ResultStatement since DBAL 2.10.2
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@wizhippo
Copy link
Contributor Author

wizhippo commented Apr 1, 2021

See doctrine/dbal#4572

@alongosz alongosz self-assigned this Apr 2, 2021
@alongosz
Copy link
Member

alongosz commented Apr 6, 2021

Hi @wizhippo. This bug exists on 2.5 LTS as well, so I need to re-target it to the proper package (it will be merged up here). More refactoring and test coverage is needed as this seem not to be too stable based on Doctrine Maintainers' response.
Closing in favor of ezsystems/ezpublish-kernel#3094

@alongosz alongosz closed this Apr 6, 2021
@wizhippo wizhippo deleted the patch-2 branch July 27, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants